Array Disarray

Why doesn't this work?

Code:

---

function parse_error($handler,$error_message,$error_code = 0)
{
        $handler["code"][] = $error_code;
        $handler["message"][] = $error_message;
        return $handler;
}

---

Nothing gets passed to the array... it's empty?? I originall tried this:

Code:

---

function parse_error($handler,$error_message,$error_code = 0)
{
        array_push($handler["code"],$error_code);
        array_push($handler["message"],$error_message);
        return $handler;
}

---

I'm guessing that's PHP? The functions look pretty normal to me. I think your problem most likely lies in how you're using them. How are you calling parse_error()? How is the $handler array be initialized before hand? Why are you passing $handler by value instead of by reference?

Yes, that's PHP... oops :D.

parse_error() adds an error to the handler much like array_push is supposed to add a node to a stack. Here is where $handler comes from:

Code:

---

function create_error_handler()
{
        return array("code" => array(),"message" => array());
}

---

There really isn't a reason why I passed it by value than by reference except that I just didn't. I tend to think of references as ugly code too. Do you think that would work? I'll try it...

Yeah you might want to give it a try - to me that looks like a useful time to pass it by reference. In any case, I'd just work my way through a request inch by inch, placing a "die()" in key places to see what the $handler var contains at certain places in time. I'm sure you'll figure out where it gets emptied. Good luck.

Wonder of all wonders, that little ampersand did the trick! Does that apply to all assosiative arrays I wonder? Is it that way purposefully in PHP? Anyway, I knew it had to be something stupifyingly simple. Thanks :eek:

If passing by reference was all you needed to do to fix the problem, than you were probably just not using your functions properly to begin with. I'm fairly certain you can pass arrays by value in PHP all the same, but passing by reference is preferable, at least in my opinion.

Generally speaking, when you need to call on complex and/or large data structures in functions, it's better to pass them by reference than by value. I'm not sure if I follow what you mean by passing-by-reference making ugly code, but either way, six of one half a dozen of the other, take your pick :)